Skip to content

Support redis.RESP3 protocol #1716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

Support redis.RESP3 protocol #1716

wants to merge 10 commits into from

Conversation

monkey92t
Copy link
Collaborator

No description provided.

monkey92t added 10 commits April 2, 2021 18:59
@monkey92t monkey92t closed this Apr 6, 2021
@vmihailenco
Copy link
Collaborator

Let me know if you need any help with design. My first impression is that pvs []*proto.Value going to be slow since we need to allocate an intermediate value before scanning the result. Reading directly into the dest variable is much more efficient...

@monkey92t
Copy link
Collaborator Author

Yes, I found the problem, I need to redesign it.

@monkey92t monkey92t mentioned this pull request Apr 16, 2021
Merged
@monkey92t monkey92t deleted the RESP3 branch April 22, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@monkey92t @vmihailenco