Update the templates to match the official ones #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhradilek
force-pushed
the
update-templates
branch
from
98e81fb to
8597db8
Compare
jhradilek
changed the title
redhat-documentation/modular-docs#236 introduced a few changes to the structure and the comments in the official templates. This commit carries these changes over to newdoc with a few notable adjustments: * I unified the empty space above and below the comment blocks. The upstream version is very inconsistent. * I unified the type of comments. The upstream version occasionally switches to line comments for no reason. * I moved the _mod-docs-content-type attribute definition in the assembly template to the top to match its position in the other templates. * I removed accidental leading spaces from some of the comments.
jhradilek
force-pushed
the
update-templates
branch
from
8597db8 to
9d98adb
Compare
jhradilek
changed the title
|
I think the choices I made accidentally address issue #42. |
|
Thanks for the updated templates. The changes are part of newdoc 2.18.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redhat-documentation/modular-docs#236 introduced a few changes to the structure and the comments in the official templates. This commit carries these changes over to
newdocwith a few notable adjustments:_mod-docs-content-typeattribute definition in the assembly template to the top to match its position in the other templates.