fix(Transition): Don't warn on cross-realm nodes #653
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node instanceOf Elementchecks return false if the node comes from a different window than where theTransitionmodule was initialized.As far as I can tell we don't care if the node is from a different window. We're only interested in the implemented interface so checking for
nodeTypeshould be sufficient.The test passes for the previous and proposed implementation without changing the error message. We could just go with
PropTypes.shape({ nodeType: PropTypes.oneOf([1]).isRequired })but the error message would not be helpful since it wouldn't mentionElementat all.Resolves #618 (comment)
Resolves #619 (comment)