Sync with react.dev @ 11cb6b59 #114
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defaults permissions to none for all workflows, and only request extra permissions when needed. Similar to facebook/react#32708, prefer the less permissive `pull_request` trigger instead.
* [ci] Fix permissions and don't use pull_request_target Defaults permissions to none for all workflows, and only request extra permissions when needed. Similar to facebook/react#32708, prefer the less permissive `pull_request` trigger instead. * [ci] Pin 3rd party actions to specific hash
facebook/react#32727 removes the `is_remote` param.
* Add React Prague community * Update link
* Remove captureOwnerStack canary banner * Update nav and site config
* update reactrouter url * Update src/content/learn/build-a-react-app-from-scratch.md --------- Co-authored-by: Ricky <[email protected]>
1. Stop using `canary` for `captureOwnerStack` sandboxes 1. Remove remaining Canary badges from `captureOwnerStack` mentions
Updated `react-ahmedabad` community link to respective domain name
Co-authored-by: Rick Hanlon <[email protected]>
… (#7682) * Fix small grammatical mistake * Update src/content/learn/reusing-logic-with-custom-hooks.md --------- Co-authored-by: Ricky <[email protected]>
Co-authored-by: Sebastian "Sebbie" Silbermann <[email protected]>
* Add React Conf conferences.md and move past conferences * Update conferences.md
GitHub Copilot web search replies that React latest version is 19.0 because 19.1 is not present in this page
Co-authored-by: “Clatron” <“[email protected]”>
* Change the word 'Function' to 'Component' * Trigger actions
This was missed in the last blog post. Also fixed the incorrect date.
Blog post for Compiler RC
Tweaks to the post.
This reverts commit 5cc9b7b.
Previously, `createFileMap` split the MDX meta string on spaces and assumed the first token was the filename. Once we prefixed code fences with `{expectedErrors: ...}`, it would incorrectly parse the meta and crash.
This PR updates createFileMap to skip tokens in the meta containing a start and end brace pair (using a stack to ensure we close on the correct brace) while tokenizing the meta string as expected.
Test plan: pages reported in #7994 no longer crash on the next PR
Closes #7994
* Ignore braces when building Sandpack file map
Previously, `createFileMap` split the MDX meta string on spaces and assumed the first token was the filename. Once we prefixed code fences with `{expectedErrors: ...}`, it would incorrectly parse the meta and crash.
This PR updates createFileMap to skip tokens in the meta containing a start and end brace pair (using a stack to ensure we close on the correct brace) while tokenizing the meta string as expected.
Test plan: pages reported in #7994 no longer crash on the next PR
Closes #7994
* Restore lint corrections from #7989
Reverts the revert now that we've fixed the bug. These pages should no longer crash:
https://react-dev-git-pr7997-fbopensource.vercel.app/learn/referencing-values-with-refs
https://react-dev-git-pr7997-fbopensource.vercel.app/learn/synchronizing-with-effects
https://react-dev-git-pr7997-fbopensource.vercel.app/learn/separating-events-from-effects
https://react-dev-git-pr7997-fbopensource.vercel.app/learn/removing-effect-dependencies
https://react-dev-git-pr7997-fbopensource.vercel.app/learn/you-might-not-need-an-effect
For local dev and CI we want to have the eslint-local-rules running, so let's make sure both have their dependencies installed. We don't use a monorepo setup here, which is why they're currently setup as a two completely independent yarn workspaces.
Adds new docs for our new eslint rules.
* Fix view transition example * Empty commit * Fix fullscreen example
* Update useEffectEvent docs for canary * Clean up prefixed imports * Fix import * Update blog post link
* Docs for `cacheSignal` * Apply suggestion from review Co-authored-by: Sebastian Markbåge <[email protected]> * Apply suggestion from review Co-authored-by: Sebastian Markbåge <[email protected]> * Update src/content/reference/react/cacheSignal.md --------- Co-authored-by: Sebastian Markbåge <[email protected]>
* docs: scaffold docs structure for Performance tracks * docs: initial draft of Tracks section * refactor: moved to reference root section and added to the sidebar * chore: updated to canary and minor changes
* Init PPR docs * Overhaul * Apply suggestions from code review --------- Co-authored-by: Sebastian Sebbie Silbermann <[email protected]>
* wip * feedback and rm canary stuff * tweak * fix json * more canary stuff * fix link * update dates * update meta description * Expand performance track section * adjust linter note * edit perf tracks down * edit perf tracks down more * tweak note * tweak useEffectEvent * formatting * tweaks * ppr * rm canary stuff * fix json * fix json * tweaks * linter note * nit * nit * link * nit * ppr * missing await * add lint v6 * fix link --------- Co-authored-by: Dan Abramov <[email protected]>
We're updating eslint-plugin-react-hooks with support for useEffectEvent usage and updated configuration options for applying the useEffectEvent and other effect rules to custom effect hooks. This adds the documentation for the config syntax and adds mention to the useEffectEvent reference page that the linter should be used to ensure proper usage of Effect Events.
* Fix Activity sandboxes * hacky fix
* Use stable release in demos with HTML output * Fix Activity sandboxes (#8035) * Fix Activity sandboxes * hacky fix * Revert "Fix Activity sandboxes (#8035)" This reverts commit f9fd07c. * Bump to 19.2 * cleanup rest of sandpacks * Pin deps * Add back package.json with third-party deps * "^" should be fixed now * add back package.json for more toastify deps * fuggin whitespace * more fuggin whitespace * fml like fr fr --------- Co-authored-by: Sebastian Sebbie Silbermann <[email protected]> Co-authored-by: Ricky <[email protected]> Co-authored-by: Rick Hanlon <[email protected]>
* Add experimental docs for Fragment refs * Update wording * Address feedback
Updates all mentions of eslint-plugin-react-hooks rc and 6.1.0 to refer to the new 6.1.1 which has important bugfixes.
Updated description of eslint-plugin-react-hooks configuration and preset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
86 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated.
Merge changes from react.dev at 11cb6b5
The following files have conflicts and may need new translations:
Please fix the conflicts by pushing new commits to this pull request, either by editing the files directly on GitHub or by checking out this branch.
DO NOT SQUASH MERGE THIS PULL REQUEST!
Doing so will "erase" the commits from main and cause them to show up as conflicts the next time we merge.