-
Notifications
You must be signed in to change notification settings - Fork 139
RFC0929: Removal of the Legacy Architecture of React Native #929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly nits, but there are a couple of points worth expanding.
Co-authored-by: Riccardo Cipolleschi <[email protected]>
Co-authored-by: Riccardo Cipolleschi <[email protected]>
Co-authored-by: Riccardo Cipolleschi <[email protected]>
Co-authored-by: Riccardo Cipolleschi <[email protected]>
Co-authored-by: Riccardo Cipolleschi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing – just a few nits I noticed while reading it through.
Co-authored-by: Mateo Guzmán <[email protected]>
Co-authored-by: Mateo Guzmán <[email protected]>
Co-authored-by: Mateo Guzmán <[email protected]>
- [ ] `RCTWrapperViewControllerHostingView` | ||
- [ ] `RCTWrapperViewManager` | ||
- [ ] `systrace_arg_t` | ||
- [ ] `UIScrollViewDelegate` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that react-native-webview is using this, but I can't find in the deprecation notices if there is a replacement. Will we document the new alternatives?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @cipolleschi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think UIScrollViewDelegate is a mistake. That class comes from UIKit, so we can't deprecate it ourselves!
Good night, sweet prince
This RFC contains the timeline and steps we're going to take for the removal of the Legacy Architecture. Any feedback is more than welcome, especially if you're on New Arch and you're still using one of those APIs listed for removal.
You can view a rendered version of the RFC here