build(ci): Improve Android e2e #828
Conversation
.circleci/config.yml
Outdated
| - image: reactnativecommunity/react-native-android | ||
| resource_class: 'medium' | ||
| working_directory: ~/async_storage | ||
| - image: cimg/android:2021.10.2-node # node 14.18.1 |
There was a problem hiding this comment.
Shouldn't this also use cimg/node:14.18.1 as above? Or android:2022.06.2?
There was a problem hiding this comment.
This image has Android SDK preinstalled, and is used to create an apk for tests. I could merge the apk creation into e2e job, since it's no longer macos.
There was a problem hiding this comment.
Is there a cost to spinning up a separate machine? I'd imagine we should stay on the same machine for as long as possible, but I don't know how CircleCI works.
There was a problem hiding this comment.
I think there's no cost for boot up, but rather the overall execution time.
I changed the config to use one executor for Android, that should simplify this a bit 👍 |
|
🎉 This PR is included in version 1.17.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 participants
Summary
Bumping few bits in our CircleCI config. Using Linux machine instead of macos to run Android e2e. Using Test Butler to make sure e2e goes smoothly.
Test Plan
Green CI