-
Notifications
You must be signed in to change notification settings - Fork 478
Async Storage v3 #1215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
krizzu
wants to merge
91
commits into
main
Choose a base branch
from
v3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Async Storage v3 #1215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AsyncStorage v3
Intro
I’ve been maintaining AsyncStorage for a while, and the growing issues have become a real burden. As I see it, the problems fall into a few categories:
All of this makes AsyncStorage harder to evolve and less reliable than it should be. My goal is to improve this library in terms of usage and maintenance.
Goals
Todo / Progress
Things to do before this is ready to go.
General
Repo
default-storage
package back to async-storage.sqlite-storage
andapi
packages. API was just a single interface, so it was moved toasync-storage
.shared-storage
as its only module. This is a Kotlin Multiplatform library for accessing the database.JavaScript API
getMany
,setMany
,removeMany
).multiGet
,multiSet
, andmultiRemove
renamed to getMany, setMany, and removeMany. Their API also changed from array-based ([key, value]
) to object-based ({ [key]: value }
).mergeItem
andmultiMerge
removed due to differences in implementation across platforms. The merging logic is best decided by the end user.createStorage
method, where a database name must be provided.AsyncStorageError
error is thrown from AsyncStorage methods.Native
Android
iOS / macOS
Windows
Web
idb
package).Documentation
async-storage/databases
directory$platform_db_directory/async-storage/databases/$databaseName/
directory, where$databaseName.sqlite
files areMigration from v2
⠀
Feel free to comment here with suggestions/ideas and let me know what you think.