Read asset content in binary mode to suppress CRLF conversion on Windows #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems reading in binary mode won't interfere with SVG and writing those inline into the HTML. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first eight bytes of a PNG file always contain the following hex values:
89 50 4e 47 0d 0a 1a 0a.However,
Asset#contentreads the file in text mode, and when using Propshaft on Windows, the first eight bytes become89 50 4e 47 0a 1a 0a 00.As a result, the browser shows: The image "..." cannot be displayed because it contains errors.
This PR adds the
mode: "rb"option to theFile.readcall to suppress the CRLF -> LF conversion on Windows.The external encoding is not affected, because it is explicitly specified.