Clean old sourcemap assets #201
Conversation
|
|
||
| def extract_path_and_digest(digested_path) | ||
| digest = digested_path.to_s[/-([0-9a-f]{7,128})\.(?!digested)[^.]+\z/, 1] | ||
| digest = digested_path.to_s[/-([0-9a-f]{7,128})\.(?!digested)/, 1] |
There was a problem hiding this comment.
This regex should be the same as in server.rb:
propshaft/lib/propshaft/server.rb
Line 38 in af557fb
Might be worth defining this as a constant on Propshaft::Asset.
There was a problem hiding this comment.
Is there a reason why the server one shouldn't be the same as this one? The PR that introduced support for multiple extensions after .digested has made the same change to the regex made here https://github.com/rails/propshaft/pull/14/files#diff-cea8115669d1b6f7ed0b417671e6b929c07d4f41b4e009b82182221f38b46955L45
I agree a constant might be worth it, so when you change it, all places use the new version
There was a problem hiding this comment.
Just not sure if we should use the same regex in all places (even though there a few different places are defining a regex like this )
This PR #171 made propshaft to maintain sourcemap files, but they should be cleaned up the same way as normal assets are.