Remove search stream endpoint #5886
Conversation
guilload
force-pushed
the
guilload/remove-search-streaming-endpoint
branch
from
88ebceb to
04f1e7a
Compare
guilload
force-pushed
the
guilload/remove-search-streaming-endpoint
branch
from
04f1e7a to
d4c9cef
Compare
| partial_request_cache_capacity: ByteSize::mb(64), | ||
| max_num_concurrent_split_streams: 100, | ||
| max_num_concurrent_split_searches: 100, | ||
| _max_num_concurrent_split_streams: None, |
There was a problem hiding this comment.
Why do we keep this in SearcherConfig if search streams is no longer supported?
There was a problem hiding this comment.
SearcherConfig has the following serde attribute: #[serde(deny_unknown_fields)]. It means that when attempting to parse a searcher config, serde will error during deserialization when encountering unknown fields. If we remove the field totally, this won't be backward compatible, so we just ignore it.
|
Omg, guys, why did you remove it??? I was about to use it, as I need only one field returned (id) from tens if not 100s of indexed fields, so I can verify presence of said ID in some other storage. Now I am guessing I have to use a search endpoint, paging, and send the whole indexed data over the wire just to pick up a single field? I don't remember seeing ability to pick which fields I need in search results (like Solr allows). |
|
Hi @tandr, |
No description provided.