drop envsubst dep #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was afraid that there might be a security issue if we expand all environment variables by default, but since we manage our configuration file, I think it's okay to use Could you please resolve conflicts? |
|
Conflicts resolved. Next, perhaps one of the |
The envsubst command is often not installed by default on minimal distros. However, the same result can be accomplished by calling a shell `eval` command which will cause the command to be evaluated with all the currently set environment varialbles considered.
|
Conflicts resolved again after |
quantonganh
reviewed
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The envsubst command is often not installed by default on minimal distros.
However, the same result can be accomplished by calling a shell
evalcommandwhich will cause the command to be evaluated with all the currently set environment
variables considered.
This change has not been tested yet.