-
Notifications
You must be signed in to change notification settings - Fork 687
Arm backend: Move rescales from MUL visitor to pass #15103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arm backend: Move rescales from MUL visitor to pass #15103
Conversation
Signed-off-by: Martin Lindström <[email protected]> Co-authored-by: Oscar Andersson <[email protected]> Change-Id: Ie6e019d21ae1868512eb81e4a0f97c3484cd3962
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15103
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 1 Pending, 3 Unrelated FailuresAs of commit 21876ea with merge base 57a7903 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
@pytorchbot label ciflow/trunk |
@pytorchbot label "partner: arm" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated CI failures
Some TOSA ops do not support INT8 as inputs and outputs. Instead, only
INT32 is supported as a whole number type. Prior to this patch, the MUL
node visitor inserted rescale ops between the data types INT8 and INT32
before and after the operator such that it will accept its input and
output.
Change this by moving the insertion of the rescale ops to the pass
InsertRescaleInt32Pass
. This will further enable optimizationsto the graph by fusing the rescale nodes.
Test plan
Test coverage is found the modified test_insert_rescale_i32_pass.py.
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai