[mypyc] feat: implement try_getting_literal in in rtuple helper [1/1]
#20032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
BobTheBuidler
commented
Oct 9, 2025
| ] | ||
|
|
||
| if items is not None: | ||
| assert left is not None |
There was a problem hiding this comment.
I wonder if it would be worth weaving the item-getting process into the equality checks so in some cases we can exit early without fully loading the tuple items
BobTheBuidler
commented
Oct 9, 2025
| if None not in literal_items: | ||
| # If all tuple items are literals we don't even need to accept the tuple | ||
| # TODO: should we use object_rprimitive? prob not, what do? | ||
| items = [LoadLiteral(literal.value, object_rprimitive) for literal in literal_items] |
There was a problem hiding this comment.
if all items are literals we can probably have a fast-false path via type check, and if the type check passes the subsequent equality checks will be much faster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO