Skip to content

Conversation

gvangool
Copy link
Contributor

Motivation:

distutils is deprecated in Python 3.10 and scheduled to be removed in Python 3.12.

It's used to create the full directory tree for storing the files, we can replace that with pathlib.Path.mkdir.

Since we already have a Path object now, we can also replace calls to os.path.join, os.stat with calls on Path.

For the tests to pass, it would be best to merge #15.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you updated the documentation related to the changes you have made?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

gvangool and others added 2 commits May 31, 2023 00:04
distutils is scheduled to be removed in Python 3.12.
It's used to create the full directory tree for storing the files, we
can replace that with
[pathlib.Path.mkdir](https://docs.python.org/3/library/pathlib.html#pathlib.Path.mkdir).

Since we already have a `Path` object now, we can also replace calls to
`os.path.join`, `os.stat` with calls on `Path`.
@ArtyomVancyan ArtyomVancyan merged commit 0bb7295 into pysnippet:master May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants