-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Clarify that the license
key in pyproject.toml
should only be set if it is consistent across all distribution files
#1908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The link failure is due to hashicorp.com claiming we are hitting them too hard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It matches the agreed clarification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This use of "distribution files" seems fairly unclear to me. The key issue to clarify is that license
can be specified if wheels built directly from source/sdist with a build frontend (e.g., with python -m build
) must have a uniform license expression. However, wheels uploaded to PyPI or other index servers cannot be assumed to have uniform licenses, because they may not have been built by a frontend but further post-processed by a tool like auditwheel
, which may change the license.
"distribution files" gives the wrong impression here (to me at least) that it applies to all wheels for a version on an index server.
I've tweaked the sentence based on feedback from @pfmoore that hopefully helps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version seems clearer and correct to me, thanks @brettcannon
license
key in pyprojcet.toml
should only be set if it is consistent across all distribution fileslicense
key in pyproject.toml
should only be set if it is consistent across all distribution files
… if it is consistent across all distribution files This change is approved at https://discuss.python.org/t/split-from-pep-639-expressing-project-vs-distribution-licenses-post-pep-639-mod-titled/90314/179 .
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
8242a73
to
3851b07
Compare
The failure isn't my doing: |
This change is approved at https://discuss.python.org/t/split-from-pep-639-expressing-project-vs-distribution-licenses-post-pep-639-mod-titled/90314/179 .
📚 Documentation preview 📚: https://python-packaging-user-guide--1908.org.readthedocs.build/en/1908/