Graceful incompatible coords handling #7912
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adjust tests adjust tests
|
@jessegrabowski as requested, I’ve just opened this PR for ticket #7891 , it’s ready for review. Thanks! |
ricardoV94
reviewed
Sep 30, 2025
| coords={"school": np.arange(eight_schools_params["J"])}, | ||
| dims={"theta": ["school"], "eta": ["school"]}, | ||
| ) | ||
| with pytest.warns(UserWarning, match="Incompatible coordinate length"): |
There was a problem hiding this comment.
Why were the coords invalid? I don't think they are supposed to be in this test, so maybe the test was faulty?
ricardoV94
reviewed
Sep 30, 2025
| idata = pm.sample(tune=5, draws=draws, chains=2, return_inferencedata=True) | ||
| thinned_idata = idata.sel(draw=slice(None, None, thin_by)) | ||
| idata.extend(pm.sample_posterior_predictive(thinned_idata)) | ||
| with pytest.warns(UserWarning, match="Incompatible coordinate length"): |
There was a problem hiding this comment.
This should only affect the draw dimension, which is not part of the model?
ricardoV94
reviewed
Sep 30, 2025
| trace = sample(chains=1, random_seed=numpy_rng) | ||
|
|
||
| ppc = sample_posterior_predictive(trace, model=model, random_seed=numpy_rng) | ||
| with pytest.warns(UserWarning, match="Incompatible coordinate length"): |
There was a problem hiding this comment.
What is the invalid coord here? We should fix the model if there's one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the internal conversion logic to use
dict_to_dataset_drop_incompatible_coordsacross all relevant backends.Related Issue
dict_to_dataset_drop_incompatible_coordseverywhere #7908Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7912.org.readthedocs.build/en/7912/