Fix pyoxidizer build #2684
Open
Fix pyoxidizer build #2684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the necessary changes to build a portable, single-file executable for the `pyfa` application using PyInstaller. The initial attempt to use PyOxidizer was unsuccessful due to persistent build failures related to the `wxPython` dependency. The build environment could not compile `wxPython` from source within the time limits, and no compatible pre-compiled wheels were available on PyPI. The successful approach involved pivoting to PyInstaller and solving the `wxPython` dependency by using the official `wxPython` extras repository. The `requirements.txt` file was updated to use a compatible version of `wxPython` (4.2.2) available as a binary wheel for Ubuntu 24.04. The `tox.ini` file was also updated to be compatible with the current environment, allowing the linter to run successfully.
The `pyoxidizer.bzl` file in the repository was a placeholder that only produced a "hello world" executable. This commit replaces it with a complete build configuration that correctly packages the pyfa application. The new configuration is based on the existing `pyfa.spec` file for PyInstaller and includes: - The main application entry point (`pyfa.py`). - All necessary Python source files. - Data files such as images, licenses, and static data. This allows building a functional, self-contained executable using `pyoxidizer build`. Note: The test suite could not be run due to issues installing the `wxPython` dependency in the testing environment. The build from source timed out, and no pre-built wheels were available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.