Handle errors in cost calculation in InstrumentedModel #2834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmojaki
commented
Sep 8, 2025
| "opentelemetry-api>=1.28.0", | ||
| "typing-inspection>=0.4.0", | ||
| "genai-prices>=0.0.22", | ||
| "genai-prices>=0.0.23", |
There was a problem hiding this comment.
There was a significant fix in price calculation logic released here, so I think this needs to be the minimum.
There was a problem hiding this comment.
Pull Request Overview
This PR improves error handling in the cost calculation within InstrumentedModel to prevent instrumentation failures. The change ensures that any unexpected errors during cost calculation result in a warning rather than crashing the instrumentation.
- Added comprehensive exception handling for cost calculation errors
- Updated the genai-prices dependency to version 0.0.23
- Added test coverage for cost calculation error scenarios
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pydantic_ai_slim/pydantic_ai/models/instrumented.py | Added exception handling for cost calculation and CostCalculationFailedWarning class |
| tests/models/test_instrumented.py | Added test case to verify warning behavior when cost calculation fails |
| pydantic_ai_slim/pyproject.toml | Updated genai-prices dependency version to 0.0.23 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Docs Preview
|
Kludex
reviewed
Sep 8, 2025
|
|
||
| import pytest | ||
| from inline_snapshot import snapshot | ||
| from inline_snapshot.extra import warns |
Kludex
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user reported an error being thrown by
.cost(): https://pydanticlogfire.slack.com/archives/C083V7PMHHA/p1757110611141589I can't repro this, but in general instrumentation shouldn't cause errors.