Skip to content

Alternative intro #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 16, 2024
Merged

Alternative intro #270

merged 10 commits into from
Dec 16, 2024

Conversation

samuelcolvin
Copy link
Member

hyperlint-ai[bot]
hyperlint-ai bot reviewed Dec 16, 2024
View reviewed changes
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:

  • Logfire
  • LLMs
  • Pydantic

sydney-runkle
sydney-runkle reviewed Dec 16, 2024
View reviewed changes
sydney-runkle
sydney-runkle approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I like this better. I like the swap of the first sentence.

I worry about folks who aren't super familiar with FastAPI, but I'm less concerned about this given that the first sentence is a generic elevator pitch.

Thanks!

@sydney-runkle sydney-runkle mentioned this pull request Dec 16, 2024
Closed
Bradley-Butcher
Bradley-Butcher reviewed Dec 16, 2024
View reviewed changes
@sydney-runkle @Bradley-Butcher
Update docs/index.md
530d94f 
Co-authored-by: Bradley <[email protected]>
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 16, 2024 •
edited
Loading

Deploying pydantic-ai with  Cloudflare Pages  Cloudflare Pages

Latest commit: 33940cc
Status: ✅  Deploy successful!
Preview URL: https://3b2d4eb1.pydantic-ai.pages.dev
Branch Preview URL: https://alternative-intro.pydantic-ai.pages.dev

View logs

summerscope
summerscope reviewed Dec 16, 2024
View reviewed changes
summerscope
summerscope reviewed Dec 16, 2024
View reviewed changes
summerscope
summerscope approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@summerscope summerscope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a styling change, suggested some text edits - commit or ignore as you like :) 👍

@samuelcolvin samuelcolvin merged commit 3aa0ea3 into main Dec 16, 2024
16 checks passed
@samuelcolvin samuelcolvin deleted the alternative-intro branch December 16, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@summerscope summerscope summerscope approved these changes

+3 more reviewers

@Bradley-Butcher Bradley-Butcher Bradley-Butcher left review comments

@hyperlint-ai hyperlint-ai[bot] hyperlint-ai[bot] left review comments

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samuelcolvin @summerscope @Bradley-Butcher @sydney-runkle