Add on_complete callback to AG-UI functions to get access to AgentRunResult

[ChuckJonas]

Fixes #2398

[ChuckJonas]

@DouweM not sure this is what you meant...

if _utils.is_async_callable(on_complete):
    await on_complete(run)

"None" is not awaitable
"None" is incompatible with protocol "Awaitable[_T_co@Awaitable]"
"await" is not present

And

else:
     await _utils.run_in_executor(on_complete, run)

Is saying it's unreachable.

[ChuckJonas]

FWIW, I just ran in my project with both a sync and async callback and it seems to work as expected... Maybe just a type issue?

[DouweM]

Weird, I'm seeing the same, looks like is_async_callable's TypeIs return annotation is subtly broken... I'm Ok with going back to what you had in that case, running this in an executor (i.e. a thread) seems less important than doing so for tools anyway.

[github-actions]

This PR is stale, and will be closed in 3 days if no reply is received.

[ChuckJonas]

This PR is stale, and will be closed in 3 days if no reply is received.

@DouweM is this still a priority?

If the type error is blocking, I can go ahead and revert back to:

if inspect.iscoroutinefunction(on_complete):
         await on_complete(completed_run)
     else:
         on_complete(completed_run)

[DouweM]

@ChuckJonas Yeah let's go back to what you had!

[ryeguard]

Thanks @ChuckJonas for suggesting and looking into this! It's something I'm also interested in using for accessing run.result.new_messages() for persisting to db.

[ChuckJonas]

@ChuckJonas Yeah let's go back to what you had!

@DouweM I think I correctly reverted these line and I rebased to resolve conflicts. AFIAK the PR should be good (not sure why the CI coverage check is failing, I believe it's unrelated but not familiar enough with the tooling to say for sure).

[DouweM]

@ChuckJonas Thanks Charlie!