Skip to content

Conversation

medaminezghal
Copy link
Contributor

This will fix the PydanticDeprecatedSince211 errors that come from pydantic>=2.11 but it will fails because misteralai should also edit it's code.

@Kludex
Copy link
Member

Kludex commented Jun 26, 2025

@Viicos previous versions of Pydantic don't support this, right?

@Viicos
Copy link
Member

Viicos commented Jun 26, 2025

@Viicos previous versions of Pydantic don't support this, right?

This should be working (both keyword and positional argument for config works in <2.11), but the version bump would have to be removed.

@Viicos Viicos changed the title This will fix PydanticDeprecatedSince211 errors Fix deprecation warning under Pydantic 2.11 Jun 26, 2025
@medaminezghal
Copy link
Contributor Author

@Viicos I solved the problems

@medaminezghal
Copy link
Contributor Author

@Viicos should I also revert the mistralai version?

@Viicos
Copy link
Member

Viicos commented Jun 26, 2025

@Viicos should I also revert the mistralai version?

Yes I think so, if the deprecation warning was present in an older mistralai version, it isn't an issue on our end (until we actually bump the minimum supported Pydantic version to 2.11, and as such enable testing on this version).

@medaminezghal
Copy link
Contributor Author

@Viicos I think it can be merged now if the tests pass

Copy link
Member

@Viicos Viicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Viicos Viicos merged commit 1c4438e into pydantic:main Jun 26, 2025
16 checks passed
@medaminezghal medaminezghal deleted the fix-PydanticDeprecatedSince211-tests branch June 26, 2025 08:47
@medaminezghal
Copy link
Contributor Author

@Viicos I've made a PR in mistralai package to fix PydanticDeprecatedSince211 that come from it in the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants