-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix deprecation warning under Pydantic 2.11 #2076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecation warning under Pydantic 2.11 #2076
Conversation
@Viicos previous versions of Pydantic don't support this, right? |
This should be working (both keyword and positional argument for |
@Viicos I solved the problems |
@Viicos should I also revert the mistralai version? |
Yes I think so, if the deprecation warning was present in an older mistralai version, it isn't an issue on our end (until we actually bump the minimum supported Pydantic version to 2.11, and as such enable testing on this version). |
@Viicos I think it can be merged now if the tests pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @medaminezghal
This will fix the
PydanticDeprecatedSince211
errors that come frompydantic>=2.11
but it will fails becausemisteralai
should also edit it's code.