Handle McpError from MCP tool calls
#1999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DouweM can u review please? |
|
Please revert the cosmetic updates. |
ppcantidio
force-pushed
the
fix/mcp-raise-error
branch
from
06ad9d2 to
7f83dd5
Compare
ppcantidio
force-pushed
the
fix/mcp-raise-error
branch
from
7f83dd5 to
8a66f59
Compare
done |
DouweM
changed the title
McpError from MCP tool calls
|
Which kind of error would be solvable retrying tho? |
|
@Kludex maybe the ones where a wrong argument was supplied? Or where there is a scope to adjust the parameters to get a better response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Summary
Fixes #1989 – runtime errors raised by the MCP backend now surface as ModelRetry, allowing the caller’s retry logic to work correctly.
Additional improvements bundled into the same patch:
1. Export hygiene – replace the accidental string‐literal all with a tuple so IDEs and static analysers discover the five public server classes.
2. Type-annotation & formatting clean-ups – wrap long generics/context-manager signatures to the Black default line length for readability.