Skip to content

BUG: Fix handling of zero-length StreamObject #3485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −1
Open

BUG: Fix handling of zero-length StreamObject #3485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fdb3f9
ROB: Deal with DictionaryObjects having streams of length 0
stefan6419846 Feb 10, 2025
61b9653
BUG: Fix handling of zero-length streams in StreamObject
Likend Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pypdf/generic/_data_structures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,7 @@ def read_unsized_from_stream(
if length is None: # if the PDF is damaged
length = -1
pstart = stream.tell()
if length > 0:
if length >= 0:
data["__streamdata__"] = stream.read(length)
else:
data["__streamdata__"] = read_until_regex(
Expand Down
11 changes: 11 additions & 0 deletions tests/test_generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1265,3 +1265,14 @@ def test_build_link__go_to_action_without_destination():
for page in reader.pages:
writer.add_page(page)
assert len(writer.pages) == len(reader.pages)


@pytest.mark.enable_socket
def test_dictionaryobject__length_0_stream():
"""Test for issue #3052."""
url = "https://github.com/user-attachments/files/18734105/correct.pdf"
name = "issue3052.pdf"
writer = PdfWriter(clone_from=BytesIO(get_data_from_url(url, name=name)))
output = BytesIO()
writer.write(output)
assert b"\n8 0 obj\n<<\n/Length 0\n>>\nstream\n\nendstream\nendobj\n" in output.getvalue()
Loading