Skip to content

BUG: Invalid Link #2450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

BUG: Invalid Link #2450

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1596d06
Update _writer.py - Invalid Link Fix #2448
rsinger417 Feb 8, 2024
fdd0c6f
Update _writer.py
rsinger417 Feb 8, 2024
4104ecc
Update _writer.py
rsinger417 Feb 8, 2024
a795c31
Update _writer.py
rsinger417 Feb 8, 2024
c1d3459
Update _writer.py
rsinger417 Feb 8, 2024
7fb4d9e
Update _writer.py
rsinger417 Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pypdf/_writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2129,9 +2129,12 @@ def add_annotation(
# destination
if to_add.get("/Subtype") == "/Link" and "/Dest" in to_add:
tmp = cast(Dict[Any, Any], to_add[NameObject("/Dest")])
# Changes target_page_index an integer to target_page an IndirectObject
pages_obj = cast(Dict[str, Any], self.get_object(self._pages))
target_page = pages_obj[PA.KIDS][tmp["target_page_index"]]
dest = Destination(
NameObject("/LinkName"),
tmp["target_page_index"],
target_page,
Fit(
fit_type=tmp["fit"], fit_args=dict(tmp)["fit_args"]
), # I have no clue why this dict-hack is necessary
Expand Down