Switch PDM TX to the DAC mode. (IDF5) #2134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What changed Replaced: * `I2S_PDM_TX_CLK_DEFAULT_CONFIG` → `I2S_PDM_TX_CLK_DAC_DEFAULT_CONFIG` * `I2S_PDM_TX_SLOT_DEFAULT_CONFIG` → `I2S_PDM_TX_SLOT_DAC_DEFAULT_CONFIG` These macros switch `line_mode` to `I2S_PDM_TX_ONE_LINE_DAC` and adjust other related fields. ### Why PDM output sounded too high-pitched when using mono audio. I assume the point of `DriverPDM` is to simulate a DAC, and this config matches that better — especially compared to the old IDF 4 “legacy” driver. Audio now sounds correct.
|
I was getting compile errors for the ESP32 in Arduino (idf version 5.5.0), so I changed it to 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
Replaced:
I2S_PDM_TX_CLK_DEFAULT_CONFIG→I2S_PDM_TX_CLK_DAC_DEFAULT_CONFIGI2S_PDM_TX_SLOT_DEFAULT_CONFIG→I2S_PDM_TX_SLOT_DAC_DEFAULT_CONFIGThese macros switch
line_modetoI2S_PDM_TX_ONE_LINE_DACand adjust other related fields.Why
PDM output sounded too high-pitched when using mono audio. I assume the point of
DriverPDMis to simulate a DAC, and this config matches that better — especially compared to the old IDF 4 “legacy” driver. Audio now sounds correct.