Added support for VBAN ping packet #2098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Awesome work on the library btw. I may eventually commit a function to also send the discovery packet since everything is already there - the only difference is in a reply bit and how you set frame window but I am not sure how one would use that on microcontroller. I will try to add example on how to set parameters in examples thought. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added definitions inside src->AudioTools->AudioLibs->VBANStream and vban->vban,h to support reply to discovery packet send from other device. I needed this in order to scan devices on the network. If the device name is not specified it will be set as device MAC address thus uniquely identifying it on the network even when dynamically DHCP managed. I have tested it both with official Voicemeeter app and my own Java implementation. I implemented this by following the VBAN protocol specs. Please merge :-). Feel free to edit if necessary.