Skip to content

Conversation

SergeAgeyev
Copy link
Contributor

Fix compile error for WiFiClientSecure

Fixed compile error in WiFiClientSecure.
The problem was wrong order of parameters in EthernetClient (probably artifact of some refactoring)
The change seems obvious, and since the whole sock is copied and default copy constructor seems to work for SecureSocketImpl, no "new" required to be here as well.
Unfortunately, I cannot test fix on the field as it requires gcc version I do not have.

Added auto-test continuous integration (CI) workflows

Also, added github workflow to test that build.sh finishes successfully after each commit.
Also added workflow to run unit tests already implemented for the core (tests are relaxed a bit, Werror option removed)

Ask permission to put workflow badges

You may add workflow status badges to Readme.md in repository root, just add these lines

[![Linux build](../../actions/workflows/c-cpp-cmake.yml/badge.svg)](../../actions/workflows/c-cpp-cmake.yml)
[![Unit tests](../../actions/workflows/unit-tests.yml/badge.svg)](../../actions/workflows/unit-tests.yml)

Probably good place to put them is here:

# An Arduino C++ Emulator Library

[![Linux build](../../actions/workflows/c-cpp-cmake.yml/badge.svg)](../../actions/workflows/c-cpp-cmake.yml)
[![Unit tests](../../actions/workflows/unit-tests.yml/badge.svg)](../../actions/workflows/unit-tests.yml)

## Using this Project as a library

I decided not to put badges in the repo, as you, as maintainer may have another/better opinion where to put them

@SergeAgeyev
Copy link
Contributor Author

Would you please merge this to main branch, as it done in rpi branch?

@pschatzmann
Copy link
Owner

pschatzmann commented Sep 30, 2025

Hallo,
I am currently working on the following topics using the rpi brach

  • upgrade to ArduinoAPI v1.5.2
  • support for Rasperry PI
  • makeing WiFiClientSecure finally work

I have integrated your (modified) changes there. This will be merged to main after I managed to perform some basic tests

@pschatzmann
Copy link
Owner

The branch has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants