Fixed issue with WiFiClientSecure. Added github CI workflows to test build.sh and run core unit tests. #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix compile error for WiFiClientSecure
Fixed compile error in WiFiClientSecure.
The problem was wrong order of parameters in EthernetClient (probably artifact of some refactoring)
The change seems obvious, and since the whole
sock
is copied and default copy constructor seems to work forSecureSocketImpl
, no "new" required to be here as well.Unfortunately, I cannot test fix on the field as it requires gcc version I do not have.
Added auto-test continuous integration (CI) workflows
Also, added github workflow to test that build.sh finishes successfully after each commit.
Also added workflow to run unit tests already implemented for the core (tests are relaxed a bit, Werror option removed)
Ask permission to put workflow badges
You may add workflow status badges to Readme.md in repository root, just add these lines
Probably good place to put them is here:
I decided not to put badges in the repo, as you, as maintainer may have another/better opinion where to put them