Update OM1.1 for UTF-8 metric names and labels #2746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of prometheus/prometheus#16093 Signed-off-by: Owen Williams <[email protected]>
ywwg
force-pushed
the
owilliams/utf8-abnf
branch
from
755a40d to
908e3a6
Compare
ywwg
commented
Oct 2, 2025
Signed-off-by: Owen Williams <[email protected]>
Signed-off-by: Owen Williams <[email protected]>
dashpole
approved these changes
Oct 3, 2025
krajorama
requested changes
Oct 6, 2025
krajorama
reviewed
Oct 7, 2025
| label-name-initial-char = ALPHA / "_" | ||
| escaped-string = *escaped-char | ||
| escaped-string = 1*escaped-char |
There was a problem hiding this comment.
Isn't this a breaking change for labels? https://prometheus.io/docs/specs/om/open_metrics_spec/#label
The format allows empty string as far as I understand.
There was a problem hiding this comment.
ah, correct -- ok we need to allow empty strings for label values but not label or metric names
|
@ywwg I'd suggest to scan the "Design considerations" section, in particular https://prometheus.io/docs/specs/om/open_metrics_spec/#metric-naming-and-namespaces . I've done it as a follow-up to relaxed suffix rules, see #2751 |
Signed-off-by: Owen Williams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of prometheus/prometheus#16093