Optimise JSON marshalling for sparse histograms #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeanette Tan <[email protected]>
Signed-off-by: Jeanette Tan <[email protected]>
zenador
force-pushed
the
sparsehistograms
branch
5 times, most recently
from
09084ca to
0ed9457
Compare
codesome
reviewed
Jan 31, 2023
Signed-off-by: Jeanette Tan <[email protected]>
Signed-off-by: Jeanette Tan <[email protected]>
…amPair Signed-off-by: Jeanette Tan <[email protected]>
Signed-off-by: Jeanette Tan <[email protected]>
zenador
force-pushed
the
sparsehistograms
branch
from
0ed9457 to
d316bd4
Compare
Signed-off-by: Jeanette Tan <[email protected]>
zenador
force-pushed
the
sparsehistograms
branch
from
d316bd4 to
18a4214
Compare
|
Thanks for the review! Updated benchmark results: |
codesome
approved these changes
Feb 2, 2023
krajorama
added a commit
to grafana/mimir
that referenced
this pull request
Feb 20, 2023
At prometheus/common@f9c1994 For prometheus/common#440 Optimise JSON marshalling for sparse histograms and floats Signed-off-by: György Krajcsovits <[email protected]>
krajorama
added a commit
to grafana/mimir
that referenced
this pull request
Feb 21, 2023
At prometheus/common@f9c1994 For prometheus/common#440 Optimise JSON marshalling for sparse histograms and floats Signed-off-by: György Krajcsovits <[email protected]>
beorn7
added a commit
that referenced
this pull request
Feb 23, 2023
This seemingly undoes #440, but all the json-iterator usage was actually pulled up into client_golang in prometheus/client_golang#1225 . Detailed explanation there. In short, we would like to keep heavy dependencies like json-iterator out of prometheus/common/model since many importers of this package aren't even interested in the JSON marshaling. Signed-off-by: beorn7 <[email protected]>
beorn7
added a commit
that referenced
this pull request
Feb 28, 2023
This seemingly undoes #440, but all the json-iterator usage was actually pulled up into client_golang in prometheus/client_golang#1225 . Detailed explanation there. In short, we would like to keep heavy dependencies like json-iterator out of prometheus/common/model since many importers of this package aren't even interested in the JSON marshaling. Signed-off-by: beorn7 <[email protected]>
radek-ryckowski
pushed a commit
to goldmansachs/common
that referenced
this pull request
May 18, 2023
This seemingly undoes prometheus#440, but all the json-iterator usage was actually pulled up into client_golang in prometheus/client_golang#1225 . Detailed explanation there. In short, we would like to keep heavy dependencies like json-iterator out of prometheus/common/model since many importers of this package aren't even interested in the JSON marshaling. Signed-off-by: beorn7 <[email protected]>
radek-ryckowski
pushed a commit
to goldmansachs/common
that referenced
this pull request
May 21, 2025
This seemingly undoes prometheus#440, but all the json-iterator usage was actually pulled up into client_golang in prometheus/client_golang#1225 . Detailed explanation there. In short, we would like to keep heavy dependencies like json-iterator out of prometheus/common/model since many importers of this package aren't even interested in the JSON marshaling. Signed-off-by: beorn7 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #417 according to suggestion in #417 (comment)
Benchmarking results: