Fix cluster settings collection when max_shards_per_node is manually set #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: akazs <[email protected]>
sysadmind
reviewed
Jul 19, 2022
|
@sysadmind Should I also generate a case putting it in the persistent settings like this? "persistent": {
"cluster": {
"max_shards_per_node": {
"frozen": "3000"
}
}
}, |
sysadmind
approved these changes
Jul 20, 2022
SuperQ
added a commit
that referenced
this pull request
Jul 28, 2022
* [FEATURE] Add metrics collection for data stream statistics #592 * [FEATURE] Support for AWS Elasticsearch using AWS SDK v2 #597 * [BUGFIX] Fix cluster settings collection when max_shards_per_node is manually set. #603 Signed-off-by: SuperQ <[email protected]>
Merged
SuperQ
added a commit
that referenced
this pull request
Jul 28, 2022
* [FEATURE] Add metrics collection for data stream statistics #592 * [FEATURE] Support for AWS Elasticsearch using AWS SDK v2 #597 * [BUGFIX] Fix cluster settings collection when max_shards_per_node is manually set. #603 Signed-off-by: SuperQ <[email protected]>
SuperQ
added a commit
that referenced
this pull request
Jul 28, 2022
* [FEATURE] Add metrics collection for data stream statistics #592 * [FEATURE] Support for AWS Elasticsearch using AWS SDK v2 #597 * [BUGFIX] Fix cluster settings collection when max_shards_per_node is manually set. #603 Signed-off-by: SuperQ <[email protected]>
jnadler
pushed a commit
to jnadler/elasticsearch_exporter
that referenced
this pull request
Oct 27, 2022
…set (prometheus-community#603) Signed-off-by: akazs <[email protected]>
jnadler
pushed a commit
to jnadler/elasticsearch_exporter
that referenced
this pull request
Oct 27, 2022
* [FEATURE] Add metrics collection for data stream statistics prometheus-community#592 * [FEATURE] Support for AWS Elasticsearch using AWS SDK v2 prometheus-community#597 * [BUGFIX] Fix cluster settings collection when max_shards_per_node is manually set. prometheus-community#603 Signed-off-by: SuperQ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: akazs [email protected]
This PR fixes #509.