Skip to content

Conversation

emilkje
Copy link
Contributor

@emilkje emilkje commented Sep 24, 2025

The deploy-projectsveltos make target was missing required dependencies
(ENVSUBST and KUBECTL) which could cause the target to fail when run
independently. This fix ensures all necessary tools are available before
executing the target.

Fixes: #1401

gianlucam76
gianlucam76 previously approved these changes Sep 24, 2025
Copy link
Member

@gianlucam76 gianlucam76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you

@gianlucam76
Copy link
Member

@emilkje would you please mind changing base to main? We dont use dev anymore. Instead main is used as the development branch and when ready to release we create a new branch (like release-1.1) and then from there we create the release.

Sorry for not noticing it before (and if there is any part of documentation that still refers to dev, please let me know so I can fix it)

Thanks

@emilkje emilkje changed the base branch from dev to main September 24, 2025 11:42
@emilkje emilkje dismissed gianlucam76’s stale review September 24, 2025 11:42

The base branch was changed.

    The deploy-projectsveltos make target was missing required dependencies
    (ENVSUBST and KUBECTL) which could cause the target to fail when run
    independently. This fix ensures all necessary tools are available before
    executing the target.

    Fixes: projectsveltos#1401
@emilkje emilkje force-pushed the build/make-deploy-projectsveltos-deps branch from d2746e1 to ad446cf Compare September 24, 2025 11:51
@emilkje
Copy link
Contributor Author

emilkje commented Sep 24, 2025

I've rebased the PR branch to main and changes the base as requested. I read the CONTRIBUTING.md guidelines and was tripped up by Contributing point 5 and the branch descriptions. I've highlighted the text below indicating the use of dev branch.

  1. Create a pull request to the dev repository.

Projectsveltos repos have three types of branches: the main branch, the dev branch and release-X branches.

The dev branch is where development happens. All the latest and greatest code, including breaking changes, happens on dev.

@gianlucam76
Copy link
Member

Thank you @emilkje

Thanks for sharing that. We forgot to change it (we used to develop in dev). So that is also something to update. Will fix it.

Thank you!

@gianlucam76 gianlucam76 merged commit 3afa8c5 into projectsveltos:main Sep 24, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make deploy-projectsveltos fails
2 participants