Skip to content

Update FlashMigrationCounter guidance to reference un-deprecated component #3694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2025
Merged

Update FlashMigrationCounter guidance to reference un-deprecated component #3694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d48c24a
Update FlashMigrationCounter guidance to reference un-deprecated comp…
tomthorogood Sep 24, 2025
5fc9e67
Update test to match suggestion for flash replacement
tomthorogood Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/primer/view_components/linters/flash_migration_counter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ class FlashMigrationCounter < BaseLinter

TAGS = %w[div].freeze
CLASSES = %w[flash].freeze
MESSAGE = "We are migrating flashes to use [Primer::Beta::Flash](https://primer.style/view-components/components/beta/flash), please try to use that instead of raw HTML."
MESSAGE = "We are migrating flashes to use [Primer::Alpha::Banner](https://primer.style/view-components/components/alpha/banner), please try to use that instead of raw HTML."
ARGUMENT_MAPPER = ArgumentMappers::Flash
COMPONENT = "Primer::Beta::Flash"
COMPONENT = "Primer::Alpha::Banner"

def map_arguments(tag, tag_tree)
# We can only autocorrect elements with simple text as content.
Expand Down
2 changes: 1 addition & 1 deletion test/lib/erblint/flash_migration_counter_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ def test_suggests_how_to_use_the_component_with_arguments
@file = "<div class=\"flash flash-warn flash-full\">flash</div>"
@linter.run(processed_source)

assert_includes(offenses.first.message, "render Primer::Beta::Flash.new(scheme: :warning, full: true)")
assert_includes(offenses.first.message, "render Primer::Alpha::Banner.new(scheme: :warning, full: true)")
end

def test_does_not_autocorrect_with_html_content
Expand Down
Loading