Skip to content

styled-react: Fix browser tests not running #6822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 15, 2025
Merged

styled-react: Fix browser tests not running #6822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b095800
actually run browser tests
siddharthkp Sep 10, 2025
02c5763
skip failing test
siddharthkp Sep 10, 2025
68a168d
rename mts to ts?
siddharthkp Sep 10, 2025
2a6b17f
surprise newline?
siddharthkp Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/styled-react/src/__tests__/primer-react.browser.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ describe('@primer/react', () => {
expect(window.getComputedStyle(container.firstElementChild!).backgroundColor).toBe('rgb(255, 0, 0)')
})

test('Select supports `sx` prop', () => {
test.skip('Select supports `sx` prop', () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skipping until we decide what to do with this, do we accept that sx should not be supported (not supported in this component since May) or do we bring it back?

render(<Select data-testid="component" sx={{background: 'red'}} />)
expect(window.getComputedStyle(screen.getByTestId('component')).backgroundColor).toBe('rgb(255, 0, 0)')
})
Expand Down
1 change: 0 additions & 1 deletion packages/styled-react/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,3 @@
"extends": "../../tsconfig.base.json",
"include": ["src", "vitest.config.ts", "vitest.config.browser.ts", "config/vitest"]
}

1 change: 1 addition & 0 deletions packages/styled-react/vitest.config.browser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ export default defineConfig({
__DEV__: true,
},
test: {
name: '@primer/styled-react (browser)',
include: ['src/**/*.browser.test.?(c|m)[jt]s?(x)'],
setupFiles: ['config/vitest/browser/setup.ts'],
browser: {
Expand Down
1 change: 1 addition & 0 deletions packages/styled-react/vitest.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import {defineConfig} from 'vitest/config'

export default defineConfig({
test: {
name: '@primer/styled-react (node)',
environment: 'node',
exclude: ['src/**/*.browser.test.?(c|m)[jt]s?(x)'],
},
Expand Down
7 changes: 6 additions & 1 deletion vitest.config.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@ import {defineConfig} from 'vitest/config'

export default defineConfig({
test: {
projects: ['packages/*/vitest.config.ts', 'packages/*/vitest.config.mts', 'packages/*/vitest.config.browser.mts'],
projects: [
'packages/*/vitest.config.ts',
'packages/*/vitest.config.mts',
'packages/*/vitest.config.browser.ts',
'packages/*/vitest.config.browser.mts',
],
},
})
Loading