Skip to content

Change contrast input background to bgColor-default #2907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2025
Merged

Change contrast input background to bgColor-default #2907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2999fb
change bg
langermank Sep 24, 2025
e2fde47
Create wet-moose-beg.md
langermank Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wet-moose-beg.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/css": minor
---

Change `contrast` input background to `bgColor-default`
3 changes: 2 additions & 1 deletion src/forms/form-control.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,9 @@ textarea.form-control {
}

// Inputs with contrast for easy light gray backgrounds against white.
// changing the value to default as to not remove the class all together, but deprecate the visual distinction for "contrast"
Copy link
Preview

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment has a grammatical error. 'all together' should be 'altogether' (one word) when meaning 'completely' or 'entirely'.

Suggested change
// changing the value to default as to not remove the class all together, but deprecate the visual distinction for "contrast"
// changing the value to default as to not remove the class altogether, but deprecate the visual distinction for "contrast"

Copilot uses AI. Check for mistakes.

Copy link
Preview

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment should start with a capital letter for consistency with standard comment formatting.

Suggested change
// changing the value to default as to not remove the class all together, but deprecate the visual distinction for "contrast"
// Changing the value to default as to not remove the class all together, but deprecate the visual distinction for "contrast"

Copilot uses AI. Check for mistakes.

.input-contrast {
background-color: var(--bgColor-muted, var(--color-canvas-inset));
background-color: var(--bgColor-default);

&:focus {
background-color: var(--bgColor-default, var(--color-canvas-default));
Expand Down
Loading