Skip to content

Conversation

kgartland-rstudio
Copy link
Contributor

Intent

black was updated to 24.3.0 here:
818d393

but it's not available for Python 3.7:
https://github.com/rstudio/rsconnect-python/actions/runs/8372241141/job/22922828215

This PR removes Python 3.7 from the testing matrix. The nightly tests now pass again:
https://github.com/rstudio/rsconnect-python/actions/runs/8375941880

Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
4536 3234 71% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 2c110f2 by action🐍

Copy link
Collaborator

@aronatkins aronatkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we missing something from our main workflow that caused this to only show up as a nightly failure?

@kgartland-rstudio
Copy link
Contributor Author

Are we missing something from our main workflow that caused this to only show up as a nightly failure?

I have no idea why it passed main initially.

@aronatkins
Copy link
Collaborator

I have no idea why it passed main initially.

Oh. It's pip install -r requirements.txt (nightly) vs pip install '.[test]' (main). 😢

Copy link
Contributor

@mmarchetti mmarchetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants