-
Notifications
You must be signed in to change notification settings - Fork 26
Bump version of black in requirements.txt #555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This identifies a bunch of whitespace adjustments that need to be made before this can be merged.
Ok, I will run |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
I think this is automatically run by CI, but to run all the checks locally: make lint |
Oh. Maybe CI won't complain because it runs |
from textwrap import dedent | ||
from rsconnect.utils_package import ( | ||
_remove_leading_zeros, # pyright: ignore[reportPrivateUsage] | ||
_remove_leading_zeros, # pyright: ignore[reportPrivateUsage] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aside: This adjustment was needed with the previous version of black, as well. We didn't see it because lint problems go unseen in CI (likely because fmt is run before lint).
@nealrichardson - I'm going to merge this as-is and fix the integration tests separately. I need those working for my changes, as well. |
Intent
Snyk picked up this CVE in
black
: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-21503This PR bumps to the latest version, which fixes it.