Skip to content

Conversation

nealrichardson
Copy link
Contributor

Intent

Snyk picked up this CVE in black: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-21503

This PR bumps to the latest version, which fixes it.

Copy link
Collaborator

@aronatkins aronatkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This identifies a bunch of whitespace adjustments that need to be made before this can be merged.

@nealrichardson
Copy link
Contributor Author

Thanks. This identifies a bunch of whitespace adjustments that need to be made before this can be merged.

Ok, I will run black on the code before merging.

Copy link

github-actions bot commented Mar 20, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
4536 3234 71% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
rsconnect/actions_content.py 66% 🟢
rsconnect/http_support.py 85% 🟢
rsconnect/log.py 71% 🟢
rsconnect/metadata.py 90% 🟢
rsconnect/models.py 84% 🟢
TOTAL 79% 🟢

updated for commit: 567a329 by action🐍

@aronatkins
Copy link
Collaborator

I think this is automatically run by CI, but to run all the checks locally:

make lint

@aronatkins
Copy link
Collaborator

Oh. Maybe CI won't complain because it runs make fmt immediately before make lint.

from textwrap import dedent
from rsconnect.utils_package import (
_remove_leading_zeros, # pyright: ignore[reportPrivateUsage]
_remove_leading_zeros, # pyright: ignore[reportPrivateUsage]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside: This adjustment was needed with the previous version of black, as well. We didn't see it because lint problems go unseen in CI (likely because fmt is run before lint).

@aronatkins
Copy link
Collaborator

@nealrichardson - I'm going to merge this as-is and fix the integration tests separately. I need those working for my changes, as well.

@aronatkins aronatkins merged commit 818d393 into master Mar 20, 2024
@aronatkins aronatkins deleted the nealrichardson-patch-1 branch March 20, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants