fix: Ensure paired server warning is removed #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
even if the app takes a while to start up Fixes #45
gadenbuie
commented
Sep 26, 2024
schloerke
reviewed
Sep 26, 2024
schloerke
reviewed
Sep 26, 2024
gadenbuie
commented
Sep 26, 2024
gadenbuie
commented
Sep 26, 2024
|
I also made the warning message an actual Bootstrap alert
|
…arning This makes it possible to use CSS to completely hide the warning message with the #shinyswatch_picker_warning selector if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45
With the current approach, if the app takes a while to start up the warning message isn't removed and sticks around forever.
To reproduce the issue in #45, add
time.sleep(2)at the start of the server function ofexamples/theme-picker/app.py.