-
Notifications
You must be signed in to change notification settings - Fork 114
Add lowercase reactive.value
, calc
, effect
#822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think we have consensus that I'm a little surprised to see |
And IF we do really want |
Oooooo. I really like the small alias functions.
|
I think we should provide a lowercase version of I think it makes sense to keep the So in short, I can roll back the |
This closes #814.
Many users have wondered why
reactive.Value
,.Calc
, and.Effect
are capitalized. There are technical reasons for this, but from a user perspective it makes more sense to just use lowercase names.This PR changes those names to lowercase, and adds aliases so that the old capitalized names still work.
This PR does not change any examples because if users on a previous version of shiny were to use the example code, it wouldn't work for them, and it would be unclear to them why. In a future release, we should update the examples to use the new lowercase names.