Skip to content

Finish todo task for sidebar test #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 27, 2023
Merged

Finish todo task for sidebar test #787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ca5ebc8
Add sidebar position tests
karangattu Oct 26, 2023
29e9c37
Refactor method
karangattu Oct 27, 2023
a8867de
remove TODO comment
karangattu Oct 27, 2023
26601f4
remove left since that is default
karangattu Oct 27, 2023
ab656f7
add a newline
karangattu Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions tests/e2e/bugs/0666-sidebar/test_sidebar_colors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@

from colors import bg_color, fg_color
from conftest import ShinyAppProc

# from controls import Sidebar
from controls import Sidebar
from playwright.sync_api import Page, expect


Expand All @@ -29,8 +28,7 @@ def test_sidebar_bg_colors(page: Page, local_app: ShinyAppProc) -> None:
expect(first_sidebar).to_have_css("background-color", bg_color)
expect(first_sidebar).to_have_css("color", fg_color)

# # TODO-karan; Test that sidebar position is left
# s1 = Sidebar(page, "s1")
# s1.expect_position("left")
# s2 = Sidebar(page, "s2")
# s2.expect_position("right")
s1 = Sidebar(page, "s1")
s1.expect_position("left")
s2 = Sidebar(page, "s2")
s2.expect_position("right")
12 changes: 12 additions & 0 deletions tests/e2e/controls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2390,10 +2390,22 @@ def __init__(self, page: Page, id: str) -> None:
loc_container="div.bslib-sidebar-layout",
)
self.loc_handle = self.loc_container.locator("button.collapse-toggle")
self.loc_position = self.loc.locator("..")

def expect_title(self, value: PatternOrStr, *, timeout: Timeout = None) -> None:
playwright_expect(self.loc).to_have_text(value, timeout=timeout)

def expect_position(
self, position: Literal["left", "right"], *, timeout: Timeout = None
) -> None:
is_right_sidebar = position == "right"
_expect_class_value(
self.loc_position,
f"sidebar-{position}",
is_right_sidebar,
timeout=timeout,
)

def expect_handle(self, exists: bool, *, timeout: Timeout = None) -> None:
playwright_expect(self.loc_handle).to_have_count(int(exists), timeout=timeout)

Expand Down