Skip to content

Conversation

schloerke
Copy link
Collaborator

Finishes changes in #642. Fixes #642

@schloerke schloerke added the Needs: E2E test An E2E test will provide guardrail against this issue in the future label Aug 15, 2023
@schloerke schloerke self-assigned this Aug 15, 2023
@schloerke schloerke marked this pull request as ready for review August 15, 2023 20:10
@schloerke schloerke requested a review from wch August 15, 2023 20:10
@icarusz icarusz requested a review from jcheng5 August 21, 2023 18:07
@jcheng5
Copy link
Collaborator

jcheng5 commented Aug 21, 2023

Please make sure this works in modules--resolve_id may need to be called.

* main:
  feat(Session): Make Session on_flush() and on_flushed() accept async functions (#693)
  Make data frame selection return row numbers, not pandas index value (#677)
  chore(api)!: Rename `ui.navset_pill_card` -> `ui.navset_card_pill` and `ui.navset_tab_card` -> `ui.navset_card_tab` (#681)
  Consolidate all testing into `tests/` folder (#683)
  Fix pyright error (#678)
  Make model score app work on Connect/Shinyapps.io (#657)
  Suppress type check for read_csv
  Synchonize input_file examples
  More realistic file import example (#582)
  Make flaky dataframe test have larger timeout (#675)
  Wrap bare value box value in `p` tag (#668)
@schloerke schloerke changed the title Add shiny.experimental.ui.popover() methods and rename experimental toggle and update methods feat(X): Add shiny.experimental.ui.popover() methods and rename experimental toggle and update methods Aug 23, 2023
@schloerke schloerke merged commit 0bc5ad0 into main Aug 23, 2023
@schloerke schloerke deleted the pop_over branch August 23, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: E2E test An E2E test will provide guardrail against this issue in the future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port latest bslib styling from R Shiny
2 participants