Skip to content

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Aug 8, 2023

Fixes #666

Missing related code change in main code: f525802

  • Changelog entry

@schloerke schloerke requested review from jcheng5 and removed request for jcheng5 August 8, 2023 15:31
@schloerke schloerke added Priority: High e.g. CSV data upload fails Needs: E2E test An E2E test will provide guardrail against this issue in the future labels Aug 8, 2023
@schloerke schloerke self-assigned this Aug 8, 2023
@schloerke schloerke requested a review from wch August 8, 2023 16:25
@schloerke schloerke marked this pull request as ready for review August 8, 2023 16:25
@jcheng5
Copy link
Collaborator

jcheng5 commented Aug 8, 2023

Tested locally

@jcheng5 jcheng5 merged commit 02a5735 into main Aug 8, 2023
@jcheng5 jcheng5 deleted the fix_broken_sidebar branch August 8, 2023 19:44
schloerke added a commit that referenced this pull request Aug 9, 2023
* main:
  docs: Add Tooltip section in experimental (#673)
  Bump version to 0.5.1
  Add missing sidebar stylesheet dep (#667)
  GitHub action cleanup (#662)
  Add a triage label to issues created by non-maintainers (#647)
  Bump version to 0.5.0.9000
  Model score example (#650)
schloerke added a commit that referenced this pull request Aug 10, 2023
* main:
  Use a renderer generator to create sync/async render methods with full typing (#621)
  docs: Add Tooltip section in experimental (#673)
  Bump version to 0.5.1
  Add missing sidebar stylesheet dep (#667)
schloerke added a commit that referenced this pull request Aug 10, 2023
* main: (26 commits)
  Use a renderer generator to create sync/async render methods with full typing (#621)
  docs: Add Tooltip section in experimental (#673)
  Bump version to 0.5.1
  Add missing sidebar stylesheet dep (#667)
  GitHub action cleanup (#662)
  Add a triage label to issues created by non-maintainers (#647)
  Bump version to 0.5.0.9000
  Model score example (#650)
  Fix malformed changelog entry
  Update CHANGELOG.md for data frame filters (#654)
  Bump version to 0.5.0
  Allow ui.update_slider to handle non-numeric values (#649)
  Add updated path to examples (#645)
  Bump griffe version
  Update README
  Fix jumpy cursor in numeric filter (#640)
  Build API docs (#633)
  Pyright: ignore docs dir
  Filtering feature for data grid/table (#592)
  Add E2E tests for accordion and autoresize (#601)
  ...
schloerke added a commit that referenced this pull request Aug 10, 2023
* main: (40 commits)
  Use a renderer generator to create sync/async render methods with full typing (#621)
  docs: Add Tooltip section in experimental (#673)
  Bump version to 0.5.1
  Add missing sidebar stylesheet dep (#667)
  GitHub action cleanup (#662)
  Add a triage label to issues created by non-maintainers (#647)
  Bump version to 0.5.0.9000
  Model score example (#650)
  Fix malformed changelog entry
  Update CHANGELOG.md for data frame filters (#654)
  Bump version to 0.5.0
  Allow ui.update_slider to handle non-numeric values (#649)
  Add updated path to examples (#645)
  Bump griffe version
  Update README
  Fix jumpy cursor in numeric filter (#640)
  Build API docs (#633)
  Pyright: ignore docs dir
  Filtering feature for data grid/table (#592)
  Add E2E tests for accordion and autoresize (#601)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: E2E test An E2E test will provide guardrail against this issue in the future Priority: High e.g. CSV data upload fails
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.5.0: sidebar layout broken, along with some other missing bslib styling
2 participants