Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions e2e/data_frame/test_data_frame.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# pyright: reportUnknownMemberType=false


import re
import time
from typing import Any, Callable

import pytest
Expand Down Expand Up @@ -310,7 +310,14 @@ def _filter_test_impl(

# Apply multiple filters, make sure we get the correct results
filter_subidir_max.fill("8")
filter_num1_min.fill("4")
# We had a bug before where typing in a decimal point would cause
# the cursor to jump to the front. Make sure that doesn't happen.
filter_num1_min.focus()
page.keyboard.press("3")
time.sleep(0.2)
page.keyboard.press(".")
time.sleep(0.2)
page.keyboard.press("9")
expect(grid.locator("tbody tr")).to_have_count(5)

# Ensure changing dataset resets filters
Expand Down
6 changes: 4 additions & 2 deletions js/dataframe/filter-numeric.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@ const FilterNumericImpl: React.FC<FilterNumericImplProps> = (props) => {
style={{ flex: "1 1 0", width: "0" }}
type="number"
placeholder={createPlaceholder(editing, "Min", props.range()[0])}
value={min}
defaultValue={min}
step="any"
onChange={(e) => {
const value = coerceToNum(e.target.value);
minInputRef.current.classList.toggle(
Expand All @@ -96,7 +97,8 @@ const FilterNumericImpl: React.FC<FilterNumericImplProps> = (props) => {
style={{ flex: "1 1 0", width: "0" }}
type="number"
placeholder={createPlaceholder(editing, "Max", props.range()[1])}
value={max}
defaultValue={max}
step="any"
onChange={(e) => {
const value = coerceToNum(e.target.value);
maxInputRef.current.classList.toggle(
Expand Down
2 changes: 1 addition & 1 deletion shiny/www/shared/dataframe/dataframe.js

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions shiny/www/shared/dataframe/dataframe.js.map

Large diffs are not rendered by default.