Skip to content

Silence figure layout warning on matplotlib 3.7.2 #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 13, 2023
Merged

Silence figure layout warning on matplotlib 3.7.2 #615

merged 2 commits into from
Jul 13, 2023

Conversation

gshotwell
Copy link
Contributor

It seems like there's a matplotlib regression which causes our CI to fail Issue #611. Since I was trying to debug this issue on another branch I went ahead and silenced that warning on the penguins app.

wch
wch approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@wch wch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, besides the one small comment.

I think it makes sense to suppress this warning given that we don’t know when the next matplotlib release (which will hopefully fix the issue) will be.

@gshotwell gshotwell mentioned this pull request Jul 13, 2023
Closed
@gshotwell gshotwell merged commit a479c32 into main Jul 13, 2023
@gshotwell gshotwell deleted the silence_matplotlib_warning branch July 13, 2023 12:18
schloerke added a commit that referenced this pull request Jul 17, 2023
@schloerke
Merge branch 'main' into shiny-theme
b6997a2 
* main:
  Silence figure layout warning on matplotlib 3.7.2 (#615)
  Duckdb example (#586)
  Add --reload-dir command line argument (#353)
  Use enhanced matplotlib type stubs (#613)
  chore: Add citation (#478)
  feat(cli): add short aliases to shiny run args (#596)
@schloerke
Copy link
Collaborator

Moved warning check into the CI test that was originally failing: 93033fd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wch wch wch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gshotwell @schloerke @wch