Skip to content

Port more bslib methods: accordion, sidebar, navset, and fill methods #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 59 commits into from
May 18, 2023
Merged

Port more bslib methods: accordion, sidebar, navset, and fill methods #481

merged 59 commits into from
May 18, 2023

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented May 11, 2023 •
edited
Loading

Also:

  • Automate dependencies and save the package versions used to create the dependency to disk
  • Example apps for some methods. (More example apps in future PRs)

Remaining:

  • page_navbar()
  • Fill methods
  • Navs
  • News entry

schloerke and others added 30 commits May 5, 2023 14:49
@schloerke
Add accordion and accordion method to shiny.experimental
c7999c5
@schloerke
Automatically get experimental deps
b11885c
@schloerke
Use parent folder for more clarity
d5c2633
@schloerke @cpsievert
Do not export bind_fill_role
a4e4c75 
Co-Authored-By: Carson Sievert <[email protected]>
@schloerke
Display the output for the accordion in the example app
5fe9805
@schloerke @cpsievert
Do not make helper methods public. Just use internal fields directly
30a901c 
Co-Authored-By: Carson Sievert <[email protected]>
@schloerke
Use the htmltools pkg version for the htmltools fill dep
a159cb7
@schloerke
CardItem class should have resolve() method
7925358
@schloerke
Update _card_item.py
b14f9b1
@schloerke
card_image() should just return a Tag and let card() auto wrap …
e037ce7 
…it in a `card_body()`
@schloerke
layout_sidebar(border=) should be a bool
80d3465
@schloerke
Update bslib dep
dd317ee
@schloerke
Rearrange order to have user classes be last
f88d577
@schloerke
Expose CardItem tagify method
641e7e4
@schloerke
Rename method; Have method leverage Tag functionality
dbfb5d2
@schloerke
Add validate_css_padding() for page_fillable()
7695996
@schloerke
Update bslib deps
78bb7fe
@schloerke
Use bslib version for htmldep
b9f4424
@schloerke
More updates to sidebar(); Add deprecated panel_sidebar() and `pane…
1a81112 
…l_main()`
@schloerke
Export sidebar methods and integrate into examples
b77d231
@schloerke
Make toggle sidebar app
9c8bf89
@schloerke
Update comments; Allow for attribs in layout_column_wrap()
a3e2617
@schloerke
bind_fill_role() now prepends new fill classes or removes existing …
b9994af 
…fill classes
@schloerke
Update _sidebar.py
ed87589
@schloerke
Update _accordion.py
991d8da
@schloerke
Leverage consolidate_attrs() with class_ and **kwargs
4697e97
@schloerke
First pass at page_navbar()
3d589cf
@schloerke
Update some imports
f596575
@schloerke
Updates from rstudio/bslib#557
f8e5a20
@schloerke
Update and trim Nav methods
b51c3fc
wch
wch reviewed May 16, 2023
View reviewed changes
wch
wch reviewed May 17, 2023
View reviewed changes
wch
wch reviewed May 17, 2023
View reviewed changes
schloerke and others added 12 commits May 17, 2023 16:20
@schloerke schloerke marked this pull request as ready for review May 18, 2023 20:40
@schloerke
Copy link
Collaborator Author

Woohoo! Merging

@schloerke schloerke merged commit 02945c7 into main May 18, 2023
@schloerke schloerke deleted the bslib_accordion branch May 18, 2023 20:52
schloerke added a commit that referenced this pull request May 23, 2023
@schloerke
Merge branch 'main' into fix-python37-protocol
c35321e 
* main: (24 commits)
  Update changelog
  Reload when .py, .css, .js, .html files change
  Port more bslib methods: accordion, sidebar, navset, and fill methods (#481)
  Update list of unsafe ports. Closes #493
  Update changelog
  Use find_namespace. Closes #325
  Fix doc links to shiny.reactive.event
  Check if asset files exist.
  PR comments
  Update shiny/ui/_include_helpers.py
  Update shiny/ui/_include_helpers.py
  Update shiny/ui/_include_helpers.py
  Update shiny/ui/_include_helpers.py
  Updates for pyright (#489)
  Typing
  linting
  Pass attrributes to tags.script
  PR Comments
  Fix import for Python 3.7
  Update development status
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wch wch wch left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schloerke @wch