Skip to content

fix(asyncio-test): fixture is no longer a valid value for asyncio #2090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2025
Merged

fix(asyncio-test): fixture is no longer a valid value for asyncio #2090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dd90a4
fixture is no longer a valid value for asyncio
karangattu Sep 23, 2025
39708dd
added an explicit wait for the “Press Enter to start the stream” defa…
karangattu Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pytest.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[pytest]
asyncio_mode=strict
# Used for ./tests/pytest/asyncio_prevent.py
asyncio_default_fixture_loop_scope=fixture
asyncio_default_fixture_loop_scope=function
testpaths=tests/pytest/
; Note: Browsers are set within `./Makefile`
addopts = --strict-markers --durations=6 --durations-min=5.0 --numprocesses auto
Expand Down
4 changes: 3 additions & 1 deletion tests/playwright/shiny/components/chat/stream-result/test_chat_stream_result.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ def test_validate_chat_stream_result(page: Page, local_app: ShinyAppProc) -> Non

expect(chat.loc).to_be_visible(timeout=10 * 1000)

chat.expect_user_input("Press Enter to start the stream", timeout=30 * 1000)

chat.send_user_input()

messages = [
Expand All @@ -34,4 +36,4 @@ def test_validate_chat_stream_result(page: Page, local_app: ShinyAppProc) -> Non
chat.expect_messages(re.compile(r"\s*".join(messages)), timeout=30 * 1000)

# Verify that the stream result is as expected
stream_result.expect.to_contain_text("Message 9")
stream_result.expect.to_contain_text("Message 9", timeout=30 * 1000)
Loading