fix: Make outside users able to read tmp files #2070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into fix/js_css_inclusion
cpsievert
reviewed
Aug 27, 2025
cpsievert
reviewed
Aug 27, 2025
cpsievert
reviewed
Aug 27, 2025
cpsievert
reviewed
Aug 28, 2025
cpsievert
reviewed
Aug 28, 2025
Co-authored-by: Carson Sievert <[email protected]>
cpsievert
reviewed
Sep 2, 2025
cpsievert
reviewed
Sep 3, 2025
cpsievert
reviewed
Sep 3, 2025
cpsievert
reviewed
Sep 3, 2025
cpsievert
reviewed
Sep 4, 2025
cpsievert
reviewed
Sep 4, 2025
There was a problem hiding this comment.
This test is for the other PR, right?
There was a problem hiding this comment.
Oh nvm, I think I see why we're adding the test -- it's not that we're directly testing this fix, it's more about adding coverage that should've already existed?
There was a problem hiding this comment.
Yes, because we're altering how we include files, I want to have a test for both "link_files" and "link" versions
cpsievert
reviewed
Sep 4, 2025
cpsievert
approved these changes
Sep 4, 2025
schloerke
added a commit
that referenced
this pull request
Sep 5, 2025
* main: fix: Make outside users able to read tmp files (#2070) docs: update module server and ui to incorporate #705 (#2044) fix: errors on bookmark are now surfaced in the Python console (#2076) Add Connect Cloud as a hosting option in README (#2074) Update changelog Update changelog fix: include_css and include_js can use files in same dir (#2069)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2061
Related to: #2079
This PR updates the temp directory into which included files are saved to resolve issues with file permissions on multi-user systems.
Testing: