fix(test): Add ability to select ui.nav_menu controllers
#2066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update NavPanel.click to first open the dropdown if the nav panel is inside a closed dropdown menu. This ensures the nav panel is interactable before attempting to click it.
Introduces an example Shiny Express app using navset_pill and navset_underline with nav_menu, and adds Playwright-based tests to verify navigation between panels. This enhances test coverage for navigation UI components.
Documented the addition of support for selecting menu items in Navset controllers to improve dropdown navigation test coverage.
Replaces the use of the | operator with Union in the type annotation for nav_factory in test_navset_menu for improved compatibility and clarity.
Moved 'from typing import Union' to the top and removed a redundant import statement. Also removed an unnecessary docstring in the test function.
schloerke
changed the title
ui.nav_menu controllers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances navigation handling for dropdown menus in the navigation panel and adds comprehensive Playwright tests for these scenarios. The most important changes include improving the logic for clicking navigation items inside dropdowns and introducing new test applications and test cases to ensure correct behavior for both pill and underline navigation sets.
Navigation logic improvements:
clickmethod inshiny/playwright/controller/_navs.pyto detect when a navigation panel is inside a closed dropdown menu and automatically open the dropdown before clicking the target item. This ensures reliable navigation interaction in dropdown scenarios.Testing enhancements:
app-express.pyundertests/playwright/shiny/components/nav/navset_menu/to provide express navigation sets with both pill and underline styles, including dropdown menus and controls.test_app.pyin the same directory, introducing parameterized Playwright tests that verify navigation between panels (including those inside dropdowns) for bothnavset_pillandnavset_underlinetypes.