Skip to content

fix(markdown-stream): normalize tag name comparison #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025
Merged

fix(markdown-stream): normalize tag name comparison #2000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b65b1c
fix: normalize tag name comparison
gadenbuie May 15, 2025
77bca61
Merge branch 'main' into fix/chat-scroll
karangattu May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/markdown-stream/markdown-stream.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ class MarkdownElement extends LightElement {
while (el) {
if (el.scrollHeight > el.clientHeight) return el;
el = el.parentElement;
if (el?.tagName === CHAT_CONTAINER_TAG) {
if (el?.tagName?.toLowerCase() === CHAT_CONTAINER_TAG.toLowerCase()) {
// This ensures that we do not accidentally scroll a parent element of the chat
// container. If the chat container itself is scrollable, a scrollable element
// would already have been identified.
Expand Down
2 changes: 1 addition & 1 deletion shiny/www/py-shiny/markdown-stream/markdown-stream.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions shiny/www/py-shiny/markdown-stream/markdown-stream.js.map
View file
Open in desktop

Large diffs are not rendered by default.

Loading