fix(MarkdownStream): width and height are now respected; set a maximum width of 680px with auto margins #1944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m width of 680px with auto margins
cpsievert
force-pushed
the
fix-markdown-stream-sizing
branch
from
c00e8d7 to
c6a9011
Compare
gadenbuie
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 3 things:
ui.output_markdown_stream()'s height/width not being respected due to<shiny-markdown-stream>beingdisplay:inline;by default.widthtomin(680px, 100%). This matches the default ofui.chat_ui()and is intended to prevent the content from becoming too wide.margin: 0 autoto also matchui.chat_ui()'s behavior of horizontally centering itself in its parent.