feat(bookmark): Allow for session.bookmark.update_query_string(query_string=) to be optional
#1934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… optional. Default to current bookmark url
schloerke
changed the title
session.bookmark.update_query_string(query_string=) to be optionalsession.bookmark.update_query_string(query_string=) to be optional
There was a problem hiding this comment.
Pull Request Overview
This PR updates the bookmark functionality to allow the query string parameter in update_query_string to be optional and, if not provided, to default to the current bookmark URL.
- Update type hints and add Optional for query_string in multiple update_query_string methods.
- Modify the implementation in one method to retrieve the current bookmark URL when query_string is None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default the
url=to current bookmark url